[PATCH] Add support for subsections to the ELF assembler. Fixes PR8717.

[Sid Manning]

On 04/10/2013 07:49 AM, Rafael Espíndola wrote:
> On 10 April 2013 02:47, Peter Collingbourne<peter at pcc.me.uk>  wrote:
>>
>>    >  Please add a test showing this.
>>
>>    To be clear, I'll add a test making sure we don't emit a relocation in this case.
>
> Please also test that we use a 2 byte jump.
>
>>    >  Please make sure we reject numbers larger than 8192.
>>
>>    I thought about this, but a seemingly undocumented feature of gas is that it supports larger numbers, as well as negative numbers, so I decided to omit the check (although it's debatable whether we need to be compatible on this).  If we decide not to support this we can probably simplify getSubsectionInsertionPoint as well.
>
> Do you depend on that feature? If not it is probably best to start
> with the more restrictive option.

Hexagon's gcc emits negative subsection numbers.  The only documented 
place I could find that suggested this is OK was in gcc/config.in, 
HAS_GAS_SUBSECTION_ORDERING.  I looked for some documented range for 
this but could not find any.

>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation