[PATCH] Allow blocks to be merged when one has an undef input to a phi.

[Nick Lewycky]

On 5 June 2013 16:24, Mark Lacey <mark.lacey at apple.com> wrote:

> Can someone please review, and commit if everything looks good?
>

+static bool CanMergeValues(Value* First, Value* Second) {

+static Value* ChooseMergedValue(Value* First, Value* Second)  {

This file is overwhelmingly star-on-the right style. Please use "Value *"
in place of "Value* " for consistency.

+  assert(CanMergeValues(First, Second));

Please add a " && message" to this assert.

--- /dev/null
+++ b/test/Transforms/SimplifyCFG/UndefPHIEdgeBlockMerge.ll

Please merge your test in with 2008-05-16-PHIBlockMerge.ll (and remove the
date from its name, date-named tests are deprecated). Possibly also
merge 2009-01-18-PHIPropCrash.ll in as well.

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130605/a17725ba/attachment.html>