[llvm] r183216 - Preserve const correctness.

dag at cray.com dag at cray.com
Tue Jun 4 10:15:12 PDT 2013


Benjamin Kramer <benny.kra at gmail.com> writes:

>> The patch LGTM, but I wonder about this last statement.  Should Entry
>> really be const if it is passed to a function taking non-const.  Your
>> patch should be able to go ahead.  I'm wondering about the larger
>> question and whether this needs investigation.
>
> __register_frame doesn't actually write to the pointer despite being
> declared as non-const. This is probably a historical wart in libgcc's
> interface.

The changed line should probably should get a comment to this effect.

                              -David



More information about the llvm-commits mailing list