[patch] Second part of pr16069
David Majnemer
david.majnemer at gmail.com
Mon Jun 3 22:58:01 PDT 2013
LGTM!
Sent from my iPhone
On Jun 3, 2013, at 8:23 PM, Rafael EspĂndola <rafael.espindola at gmail.com> wrote:
> Hi David,
>
> The attached patch fixes the second part of pr16069. I have tested
> that the original C testcase is also fixed.
>
> The problem this time seems to be a thinko. We were assuming than in the CFG
>
> A
> | \
> | B
> | /
> C
>
> speculating the basic block B would cause only the the phi value for
> the B->C edge would be speculated. That is not true, the phi's as
> semantically in the edges, so if the A->B->C path is taken, any code
> needed for A->C is not executed and we have to consider it too when
> deciding to speculate B.
>
> Cheers,
> Rafael
> <t.patch>
More information about the llvm-commits
mailing list