[llvm] r183132 - R600/SI: Fixup CopyToReg register class in PostprocessISelDAG()

[Sean Silva]

On Mon, Jun 3, 2013 at 11:22 AM, Tom Stellard <tom at stellard.net> wrote:

> On Mon, Jun 03, 2013 at 02:02:53PM -0400, Rafael Ávila De Espíndola wrote:
> > Test case ?
> >
> Hi Rafael,
>
> There are tests for these bugs in later commits mostly
> work-item-intrinsics.ll
>
> Most of these bugs were uncovered while working on a new feature for the
> backend.  Usually when this happens I make commits like this:
>
> r1 - Bug Fix #1
> r2 - Bug Fix #2
> r3 - New Feature + Bug tests
>
> I don't like to push commits that have know bugs, even if the bug fix
> is coming in the next commit.  The main reason for this is to make the
> history more easily bisectable in case of other bugs.  Unfortunately,
> this meas that tests are not included in the same commit as the fixes,
> but I consider a cleaner history more important.
>

Then please indicate in the commit message that tests are forthcoming in a
future patch. But really, it makes review much easier if you just include
the tests with the commit.

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130603/a63dbcfa/attachment.html>