[PATCH] ASan Linux MIPS32 support

Jyun-Yan You jyyou at cs.nctu.edu.tw
Mon Jun 3 07:39:53 PDT 2013


I have no commit access.
Could you commit them?


On Mon, Jun 3, 2013 at 10:32 PM, Kostya Serebryany <kcc at google.com> wrote:

> Both are ok with a small lexical nit.
> Do you have commit access or you want me to commit?
>
>
> On Mon, Jun 3, 2013 at 5:18 PM, Jyun-Yan You <jyyou at cs.nctu.edu.tw> wrote:
>
>> I created two reviews. One is for LLVM and another is for compiler-rt.
>>
>> LLVM: http://llvm-reviews.chandlerc.com/D909
>> compiler-rt: http://llvm-reviews.chandlerc.com/D908
>>
>> As for build bot, unfortunately, I have no plan.
>> All I can do is test as frequently as possible.
>>
>>
>> On Mon, Jun 3, 2013 at 3:48 PM, Kostya Serebryany <kcc at google.com> wrote:
>>
>>> Hi Jyun-Yan,
>>>
>>> The patches look almost perfect, but may I ask you to send them using
>>> http://llvm.org/docs/Phabricator.html ?
>>> (This is not a requirement in the LLVM land, but is our strong
>>> preference for the sanitizer code)
>>> One thing that I noticed is __attribute__((aligned(16))), for which we
>>> prefer to use the ALIGNED macro from
>>> sanitizer_common/sanitizer_internal_defs.h.
>>>
>>> The main question about the MIPS support is whether you are planing to
>>> have a public build bot running asan tests?
>>> If not, there is a good chance that we will be breaking it every other
>>> week.
>>>
>>> Thanks!
>>>
>>> --kcc
>>>
>>>
>>>
>>> On Mon, Jun 3, 2013 at 8:44 AM, Jyun-Yan You <jyyou at cs.nctu.edu.tw>wrote:
>>>
>>>> These patches add AddressSanitizer Linux MIPS32 support.
>>>> The shadow offset is calculated from TASK_UNMAPPED_BASE of Linux MIPS32.
>>>> The LLVM patch also makes the poison value use target endian instead of
>>>> host.
>>>>
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130603/e5545331/attachment.html>


More information about the llvm-commits mailing list