[compiler-rt] r182848 - Fix MSVC warnings at the -W2 level

Timur Iskhodzhanov timurrrr at google.com
Wed May 29 10:25:52 PDT 2013


2013/5/29 David Blaikie <dblaikie at gmail.com>

> -    SizeAdd(-b->size);
>> +    // FIXME: should probably add SizeSub method?
>> +    // See
>> https://code.google.com/p/thread-sanitizer/issues/detail?id=20
>> +    SizeAdd(0 - b->size);
>>
>
> This seems like a strange transformation to make - what was wrong with the
> original code? (does SizeAdd take an unsigned? If so, this doesn't seem
> like a great improvement...)
>

Yes, it was and is unsigned.
The only reason for this particular change is to silence the warning.
The bug is filed, a proper fix is pending.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130529/8f71c76a/attachment.html>


More information about the llvm-commits mailing list