<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">2013/5/29 David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank" class="cremed">dblaikie@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">-    SizeAdd(-b->size);<br>
+    // FIXME: should probably add SizeSub method?<br>
+    // See <a href="https://code.google.com/p/thread-sanitizer/issues/detail?id=20" target="_blank" class="cremed">https://code.google.com/p/thread-sanitizer/issues/detail?id=20</a><br>
+    SizeAdd(0 - b->size);<br></blockquote><div><br></div></div><div>This seems like a strange transformation to make - what was wrong with the original code? (does SizeAdd take an unsigned? If so, this doesn't seem like a great improvement...)</div>

</blockquote></div><br>Yes, it was and is unsigned.</div><div class="gmail_extra">The only reason for this particular change is to silence the warning.</div><div class="gmail_extra">The bug is filed, a proper fix is pending.</div>

</div>