[PATCH, RFC] Recognize ValueType operands in source patterns for fast-isel
Jakob Stoklund Olesen
stoklund at 2pi.dk
Wed May 22 13:39:34 PDT 2013
On May 22, 2013, at 12:55 PM, Bill Schmidt <wschmidt at linux.vnet.ibm.com> wrote:
> It has been suggested that it might be appropriate to attach the patch.
> Oops. Please see below.
>
> Thanks,
> Bill
>
> On Wed, 2013-05-22 at 14:39 -0500, Bill Schmidt wrote:
>> Recognize ValueType operands in source patterns for fast-isel.
>>
>> Currently the fast-isel table generator recognizes registers, register
>> classes, and immediates for source pattern operands. ValueType
>> operands are not recognized. This is not a problem for existing
>> targets with fast-isel support, but will not work for targets like
>> PowerPC and SPARC that use types in source patterns.
>>
>> The proposed patch allows ValueType operands and treats them in the
>> same manner as register classes. There is no convenient way to map
>> from a ValueType to a register class, but there's no need to do so.
>> The table generator already requires that all types in the source
>> pattern be identical, and we know the register class of the output
>> operand already. So we just assign that register class to any
>> ValueType operands we encounter.
>>
>> Does this look OK to apply?
LGTM.
/jakob
More information about the llvm-commits
mailing list