[llvm] r182493 - Fix StringMapIterator compile errors for non-MSVC compilers.

David Blaikie dblaikie at gmail.com
Wed May 22 11:12:30 PDT 2013


On Wed, May 22, 2013 at 10:32 AM, Reid Kleckner <reid at kleckner.net> wrote:

> Author: rnk
> Date: Wed May 22 12:32:15 2013
> New Revision: 182493
>
> URL: http://llvm.org/viewvc/llvm-project?rev=182493&view=rev
> Log:
> Fix StringMapIterator compile errors for non-MSVC compilers.
>
> Modified:
>     llvm/trunk/include/llvm/ADT/StringMap.h
>
> Modified: llvm/trunk/include/llvm/ADT/StringMap.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/StringMap.h?rev=182493&r1=182492&r2=182493&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/ADT/StringMap.h (original)
> +++ llvm/trunk/include/llvm/ADT/StringMap.h Wed May 22 12:32:15 2013
> @@ -457,7 +457,7 @@ private:
>  template<typename ValueTy>
>  class StringMapIterator : public StringMapConstIterator<ValueTy> {
>  public:
> -  StringMapIterator() : StringMapConstIterator() {}
> +  StringMapIterator() : StringMapConstIterator<ValueTy>() {}
>

Could we just drop the base ctor invocation, since it's the default anyway?


>    explicit StringMapIterator(StringMapEntryBase **Bucket,
>                               bool NoAdvance = false)
>      : StringMapConstIterator<ValueTy>(Bucket, NoAdvance) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130522/85f13abb/attachment.html>


More information about the llvm-commits mailing list