<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 22, 2013 at 10:32 AM, Reid Kleckner <span dir="ltr"><<a href="mailto:reid@kleckner.net" target="_blank">reid@kleckner.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br>
Date: Wed May 22 12:32:15 2013<br>
New Revision: 182493<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=182493&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=182493&view=rev</a><br>
Log:<br>
Fix StringMapIterator compile errors for non-MSVC compilers.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ADT/StringMap.h<br>
<br>
Modified: llvm/trunk/include/llvm/ADT/StringMap.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/StringMap.h?rev=182493&r1=182492&r2=182493&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/StringMap.h?rev=182493&r1=182492&r2=182493&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/include/llvm/ADT/StringMap.h (original)<br>
+++ llvm/trunk/include/llvm/ADT/StringMap.h Wed May 22 12:32:15 2013<br>
@@ -457,7 +457,7 @@ private:<br>
 template<typename ValueTy><br>
 class StringMapIterator : public StringMapConstIterator<ValueTy> {<br>
 public:<br>
-  StringMapIterator() : StringMapConstIterator() {}<br>
+  StringMapIterator() : StringMapConstIterator<ValueTy>() {}<br></blockquote><div><br></div><div style>Could we just drop the base ctor invocation, since it's the default anyway?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

   explicit StringMapIterator(StringMapEntryBase **Bucket,<br>
                              bool NoAdvance = false)<br>
     : StringMapConstIterator<ValueTy>(Bucket, NoAdvance) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>