[PATCH] [Multiprecision Arithmetic Optimization] Teach SelectionDAG how to promote the integer carry result of {add, sub}{c, e} to a larger integer type.
Michael Gottesman
mgottesman at apple.com
Thu May 16 10:39:23 PDT 2013
Ok. I will post an updated patch in a bit.
On May 15, 2013, at 6:33 PM, Sean Silva <silvas at purdue.edu> wrote:
> + SDValue Ops[3] = { N->getOperand(0), N->getOperand(1) };
>
> Having an array of size 3 with only two initializers seems confusing in the sense that when I see this I think to myself "is this intentional, or is it a bug?". Don't make the reader guess whether this is a bug and instead explicitly list out 3 entries.
>
> -- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130516/773a6c66/attachment.html>
More information about the llvm-commits
mailing list