<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Ok. I will post an updated patch in a bit.</div><br><div><div>On May 15, 2013, at 6:33 PM, Sean Silva <<a href="mailto:silvas@purdue.edu">silvas@purdue.edu</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr">+ SDValue Ops[3] = { N->getOperand(0), N->getOperand(1) };<br><div><br></div><div>Having an array of size 3 with only two initializers seems confusing in the sense that when I see this I think to myself "is this intentional, or is it a bug?". Don't make the reader guess whether this is a bug and instead explicitly list out 3 entries.</div><div><br></div><div>-- Sean Silva</div></div></div></blockquote></div><br></body></html>