[llvm] r181868 - Use only explicit bool conversion operators

[David Blaikie]

On Wed, May 15, 2013 at 9:42 AM, David Blaikie <dblaikie at gmail.com> wrote:

>
>
>
> On Wed, May 15, 2013 at 2:01 AM, Timur Iskhodzhanov <timurrrr at google.com>wrote:
>
>> 2013/5/15 David Blaikie <dblaikie at gmail.com>:
>> > +++ llvm/trunk/lib/Support/Windows/Windows.h Wed May 15 02:36:59 2013
>> > @@ -75,7 +75,7 @@ public:
>> >    }
>> >
>> >    // True if Handle is valid.
>> > -  operator bool() const {
>> > +  LLVM_EXPLICIT operator bool() const {
>> >      return HandleTraits::IsValid(Handle) ? true : false;
>> >    }
>>
>> You've forgotten to IWYU.
>> Hopefully r181873 is the right fix.
>>
>
> Yep, looks fine - sorry for the breakage. (you could use
> LLVM_DELETED_FUNCTION for the ScopedHandle copy operations too, not that
> there'
>
>
Not that there's much point in a Windows-only header. (side note: might be
nice to pull ScopedHandle (& anything else possible) out into generic LLVM
headers - maybe with unit tests, then this would've ideally broken even for
a non-Windows developer such as myself)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130515/91f3c351/attachment.html>