[llvm] r181868 - Use only explicit bool conversion operators

David Blaikie dblaikie at gmail.com
Wed May 15 09:42:59 PDT 2013


On Wed, May 15, 2013 at 2:01 AM, Timur Iskhodzhanov <timurrrr at google.com>wrote:

> 2013/5/15 David Blaikie <dblaikie at gmail.com>:
> > +++ llvm/trunk/lib/Support/Windows/Windows.h Wed May 15 02:36:59 2013
> > @@ -75,7 +75,7 @@ public:
> >    }
> >
> >    // True if Handle is valid.
> > -  operator bool() const {
> > +  LLVM_EXPLICIT operator bool() const {
> >      return HandleTraits::IsValid(Handle) ? true : false;
> >    }
>
> You've forgotten to IWYU.
> Hopefully r181873 is the right fix.
>

Yep, looks fine - sorry for the breakage. (you could use
LLVM_DELETED_FUNCTION for the ScopedHandle copy operations too, not that
there'
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130515/7b3e68fa/attachment.html>


More information about the llvm-commits mailing list