[PATCH] [lld] Add comments to InputFiles::searchLibraries() arguments.

[Rui Ueyama]

I'm going to commit this, because this is really trivial change so it can
be reviewed after committed.


On Thu, Apr 25, 2013 at 5:17 AM, Rui Ueyama <ruiu at google.com> wrote:

> Hi kledzik,
>
> http://llvm-reviews.chandlerc.com/D726
>
> Files:
>   lib/Core/Resolver.cpp
>
> Index: lib/Core/Resolver.cpp
> ===================================================================
> --- lib/Core/Resolver.cpp
> +++ lib/Core/Resolver.cpp
> @@ -196,7 +196,11 @@
>        StringRef undefName = undefAtom->name();
>        // load for previous undefine may also have loaded this undefine
>        if (!_symbolTable.isDefined(undefName)) {
> -        _inputFiles.searchLibraries(undefName, true, true, false, *this);
> +        _inputFiles.searchLibraries(undefName,
> +                                    true,   // searchSharedLibs
> +                                    true,   // searchArchives
> +                                    false,  // dataSymbolOnly
> +                                    *this);
>        }
>      }
>      // search libraries for overrides of common symbols
> @@ -209,10 +213,13 @@
>          const Atom *curAtom = _symbolTable.findByName(tentDefName);
>          assert(curAtom != nullptr);
>          if (const DefinedAtom* curDefAtom =
> dyn_cast<DefinedAtom>(curAtom)) {
> -          if (curDefAtom->merge() == DefinedAtom::mergeAsTentative ) {
> +          if (curDefAtom->merge() == DefinedAtom::mergeAsTentative) {
>              // Still tentative definition, so look for override.
> -            _inputFiles.searchLibraries(tentDefName, searchSharedLibs,
> -                                        searchArchives, true, *this);
> +            _inputFiles.searchLibraries(tentDefName,
> +                                        searchSharedLibs,
> +                                        searchArchives,
> +                                        true,  // dataSymbolOnly
> +                                        *this);
>            }
>          }
>        }
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130508/6fceb1f6/attachment.html>