<div dir="ltr">I'm going to commit this, because this is really trivial change so it can be reviewed after committed.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Apr 25, 2013 at 5:17 AM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi kledzik,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D726" target="_blank">http://llvm-reviews.chandlerc.com/D726</a><br>
<br>
Files:<br>
  lib/Core/Resolver.cpp<br>
<br>
Index: lib/Core/Resolver.cpp<br>
===================================================================<br>
--- lib/Core/Resolver.cpp<br>
+++ lib/Core/Resolver.cpp<br>
@@ -196,7 +196,11 @@<br>
       StringRef undefName = undefAtom->name();<br>
       // load for previous undefine may also have loaded this undefine<br>
       if (!_symbolTable.isDefined(undefName)) {<br>
-        _inputFiles.searchLibraries(undefName, true, true, false, *this);<br>
+        _inputFiles.searchLibraries(undefName,<br>
+                                    true,   // searchSharedLibs<br>
+                                    true,   // searchArchives<br>
+                                    false,  // dataSymbolOnly<br>
+                                    *this);<br>
       }<br>
     }<br>
     // search libraries for overrides of common symbols<br>
@@ -209,10 +213,13 @@<br>
         const Atom *curAtom = _symbolTable.findByName(tentDefName);<br>
         assert(curAtom != nullptr);<br>
         if (const DefinedAtom* curDefAtom = dyn_cast<DefinedAtom>(curAtom)) {<br>
-          if (curDefAtom->merge() == DefinedAtom::mergeAsTentative ) {<br>
+          if (curDefAtom->merge() == DefinedAtom::mergeAsTentative) {<br>
             // Still tentative definition, so look for override.<br>
-            _inputFiles.searchLibraries(tentDefName, searchSharedLibs,<br>
-                                        searchArchives, true, *this);<br>
+            _inputFiles.searchLibraries(tentDefName,<br>
+                                        searchSharedLibs,<br>
+                                        searchArchives,<br>
+                                        true,  // dataSymbolOnly<br>
+                                        *this);<br>
           }<br>
         }<br>
       }<br>
</blockquote></div><br></div>