[PATCH] [nolibc] Change internal syscall API to remove reliance on libc's errno.

Evgeniy Stepanov eugenis at google.com
Wed May 8 02:25:58 PDT 2013



================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:276
@@ -275,5 +275,3 @@
 
-#define HANDLE_EINTR(res, f) {                               \
-  do {                                                                  \
-    res = (f);                                                         \
-  } while (res == -1 && errno == EINTR); \
+#define HANDLE_EINTR(res, f) { \
+  int rverrno; \
----------------
Please run this through clang-format, it knows where to put \ symbols better than any human.

================
Comment at: lib/sanitizer_common/sanitizer_posix.cc:83
@@ +82,3 @@
+  uptr res = internal_munmap(addr, size);
+  int reserrno;
+  if (internal_iserror(res, &reserrno)) {
----------------
Unused variable.


http://llvm-reviews.chandlerc.com/D756



More information about the llvm-commits mailing list