[PATCH] [nolibc] Change internal syscall API to remove reliance on libc's errno.

Kostya Serebryany kcc at google.com
Wed May 8 02:01:17 PDT 2013


  One nit. I'd ask eugenis@ to review the rest.


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:68
@@ -67,1 +67,3 @@
 
+#ifdef __x86_64__
+
----------------
I would prefer to have platform-specific syscall implementation in separate header files. 
For now, let's have sanitizer_syscall_x86_64.h and sanitizer_syscall_generic.h

Then, the .cc file will have

#ifdef ARHC1
#include sanitizer_syscall_ARHC1.h
#elif defined ARHC2
#include sanitizer_syscall_ARHC2.h
#else 
#include sanitizer_syscall_generic.h
#endif


http://llvm-reviews.chandlerc.com/D756



More information about the llvm-commits mailing list