[PATCH][lld] Begin AArch64 support
Shankar Easwaran
shankare at codeaurora.org
Mon May 6 10:12:50 PDT 2013
Hi Tim,
The patch looks good except for these
a) I dont see any relocations being handled
b) How are you testing it, if you dont have any relocations added ?
> But I couldn't see a way to test converting an "R_AARCH64_..." string
> into its internal representation (i.e. yaml -> ELF -> something
> useful). "lld -core" didn't seem to want to do anything
> target-specific no matter what I told it, and "lld -flavor gnu"
> persisted in thinking I was giving it a linker script rather than a
> YAMLised ELF file.
The way to test would be :-
lld -flavor gnu -target [x86_64|hexagon|x86] ....
For your case you need to handle aarch64 seperately (see lld-core.cpp).
* You would need to change lld-core.cpp to recognize aarch64.
Thanks
Shankar Easwaran
On 5/6/2013 11:43 AM, Tim Northover wrote:
> Hi all,
>
> I've been poking around at lld a bit today (purely for my own
> entertainment on the bank-holiday), trying to work out how much is
> involved in adding a new target.
>
> The attached patch makes a very basic start on AArch64, essentially
> containing just enough class definitions to compile and teaching lld
> about the names of our relocations (well, the ones LLVM itself knows
> about anyway).
>
> Most of the features (such as they are) are tested, I believe.
>
> But I couldn't see a way to test converting an "R_AARCH64_..." string
> into its internal representation (i.e. yaml -> ELF -> something
> useful). "lld -core" didn't seem to want to do anything
> target-specific no matter what I told it, and "lld -flavor gnu"
> persisted in thinking I was giving it a linker script rather than a
> YAMLised ELF file.
>
> Can I commit in broad terms, and if so should I break it up into its
> three testable bits (triviality; read R_AARCH strings; write R_AARCH
> strings) or leave it as is?
>
> Cheers.
>
> Tim.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130506/9f79f4db/attachment.html>
More information about the llvm-commits
mailing list