<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Tim,<br>
<br>
The patch looks good except for these <br>
<br>
a) I dont see any relocations being handled<br>
b) How are you testing it, if you dont have any relocations added
?<br>
<br>
<pre wrap="">> But I couldn't see a way to test converting an "R_AARCH64_..." string
> into its internal representation (i.e. yaml -> ELF -> something
> useful). "lld -core" didn't seem to want to do anything
> target-specific no matter what I told it, and "lld -flavor gnu"
> persisted in thinking I was giving it a linker script rather than a
> YAMLised ELF file.</pre>
The way to test would be :-<br>
<br>
lld -flavor gnu -target [x86_64|hexagon|x86] ....<br>
<br>
For your case you need to handle aarch64 seperately (see
lld-core.cpp).<br>
<br>
* You would need to change lld-core.cpp to recognize aarch64.<br>
<br>
Thanks<br>
<br>
Shankar Easwaran<br>
<br>
On 5/6/2013 11:43 AM, Tim Northover wrote:<br>
</div>
<blockquote
cite="mid:CAFHTzf+C=9q0KNKxNWyGVY=CMQ_ZvSeyrz70dhuUVpUT9HfeYA@mail.gmail.com"
type="cite">
<pre wrap="">Hi all,
I've been poking around at lld a bit today (purely for my own
entertainment on the bank-holiday), trying to work out how much is
involved in adding a new target.
The attached patch makes a very basic start on AArch64, essentially
containing just enough class definitions to compile and teaching lld
about the names of our relocations (well, the ones LLVM itself knows
about anyway).
Most of the features (such as they are) are tested, I believe.
But I couldn't see a way to test converting an "R_AARCH64_..." string
into its internal representation (i.e. yaml -> ELF -> something
useful). "lld -core" didn't seem to want to do anything
target-specific no matter what I told it, and "lld -flavor gnu"
persisted in thinking I was giving it a linker script rather than a
YAMLised ELF file.
Can I commit in broad terms, and if so should I break it up into its
three testable bits (triviality; read R_AARCH strings; write R_AARCH
strings) or leave it as is?
Cheers.
Tim.
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation</pre>
</body>
</html>