[PATCH] Allow ParserMatchClass attribute on RegisterClass

Ulrich Weigand Ulrich.Weigand at de.ibm.com
Thu Apr 25 10:35:42 PDT 2013


Hal Finkel <hfinkel at anl.gov> wrote on 02.04.2013 15:27:16:

> ----- Original Message -----
> > From: "Ulrich Weigand" <Ulrich.Weigand at de.ibm.com>
> > To: "Hal Finkel" <hfinkel at anl.gov>

> > Hal, would you be OK with changing the PowerPC back-end to
> > pervasively
> > use RegisterOperand predicates instead of plain RegisterClass?
>
> Yes.
>
> >
> > One question would be the naming; I guess as precedent for operand
> > predicates is to be fully lower case, maybe it would make sense to
> > create a RegisterOperand corresponding to every RegisterClass, where
> > the name of the RegisterOperand is simply the lower-case version of
> > the name of the RegisterClass?   E.g.
> >    GPRC --> gprc
> >    G8RC --> g8rc
> >    VRRC --> vrrc
> >
> > (This has the additional advantage that a global search-and-replace
> > will not mess up 80-column limits etc.)
>
> Sounds good to me.

Here's a patch that implements this.  Does this look OK?   If so, should
I commit it right away or wait until the asm parser itself is ready?

(See attached file: diff-llvm-asm-regclass)

Bye,
Ulrich
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff-llvm-asm-regclass
Type: application/octet-stream
Size: 136404 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130425/dc72ea94/attachment.obj>


More information about the llvm-commits mailing list