[PATH] Correct treatment for ARM-Thumb2 hint encodings

[Quentin Colombet]

Hi Mihail,

You shouldn’t set the -disassemble option for your .s tests.
Other than that, LGTM.

Thanks,

-Quentin

On Apr 25, 2013, at 7:21 AM, Mihail Popa <Mihail.Popa at arm.com> wrote:

> Hi.
> 
> This is the long delayed follow up patch to the similar issue encountered with ARM encodings. The issue is slightly more complex because the nop-compatible hint space for Thumb actually overlaps the encoding space of the CPS instruction. In actuality, hints can be defined as CPS instructions where imod and M bits are all nil.
> 
> Because tablegen does not support != operator in let expressions, the only tablegen-only solution would be to define multiple instructions, one for each imod setting. This would pollute the td file and bring no real value. Instead I propose that we should handle decoding of permitted nop-compatible hints (i.e. nop, yield, wfi, wfe, sev) in DecodeT2CPSInstruction.
> 
> The patch also adds a proper diagnostic message for Imm0_4 and updates all tests. Please note that this patch contains new files! The person who will commit must to a svn add for these first!.
> 
> Thanks,
> Mihai<LLVM-722.thumb_hints.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130425/aa1caa94/attachment.html>