<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Mihail,<div><br></div><div>You shouldn’t set the -disassemble option for your .s tests.</div><div>Other than that, LGTM.</div><div><br></div><div>Thanks,</div><div><br><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div><div>On Apr 25, 2013, at 7:21 AM, Mihail Popa <<a href="mailto:Mihail.Popa@arm.com">Mihail.Popa@arm.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Hi.<br><br>This is the long delayed follow up patch to the similar issue encountered with ARM encodings. The issue is slightly more complex because the nop-compatible hint space for Thumb actually overlaps the encoding space of the CPS instruction. In actuality, hints can be defined as CPS instructions where imod and M bits are all nil.<br><br>Because tablegen does not support != operator in let expressions, the only tablegen-only solution would be to define multiple instructions, one for each imod setting. This would pollute the td file and bring no real value. Instead I propose that we should handle decoding of permitted nop-compatible hints (i.e. nop, yield, wfi, wfe, sev) in DecodeT2CPSInstruction.<br><br>The patch also adds a proper diagnostic message for Imm0_4 and updates all tests. Please note that this patch contains new files! The person who will commit must to a svn add for these first!.<br><br>Thanks,<br>Mihai<span><LLVM-722.thumb_hints.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></body></html>