[PATCH] Fix for PR 14965: Better error message for GEP with partially defined contents

[Nadav Rotem]

LGTM.  


+  Type *BaseType = Ptr->getType();
+  PointerType *BasePointerType;
+  if (!(BasePointerType = dyn_cast<PointerType>(BaseType->getScalarType())))

I would write this as:

PointerType *BasePointerType = dyn_cast<PointerType>(BaseType->getScalarType());
if (!BasePointerType) ...



On Apr 22, 2013, at 9:14 AM, Eli Bendersky <eliben at google.com> wrote:

> Ping!
> 
> 
> On Thu, Apr 18, 2013 at 6:26 PM, Eli Bendersky <eliben at google.com> wrote:
> Attached is a fix to PR 14965 (http://llvm.org/bugs/show_bug.cgi?id=14965).
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130422/63aa6598/attachment.html>