<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>LGTM. </div><div><br></div><div><br></div><div><div>+ Type *BaseType = Ptr->getType();</div><div>+ PointerType *BasePointerType;</div><div>+ if (!(BasePointerType = dyn_cast<PointerType>(BaseType->getScalarType())))</div></div><div><br></div><div>I would write this as:</div><div><br></div><div><div>PointerType *BasePointerType = dyn_cast<PointerType>(BaseType->getScalarType());</div><div>if (!BasePointerType) ...</div></div><div><br></div><div><br></div><br><div><div>On Apr 22, 2013, at 9:14 AM, Eli Bendersky <<a href="mailto:eliben@google.com">eliben@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr">Ping!</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Apr 18, 2013 at 6:26 PM, Eli Bendersky<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:eliben@google.com" target="_blank">eliben@google.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div dir="ltr"><pre>Attached is a fix to PR 14965 (<a href="http://llvm.org/bugs/show_bug.cgi?id=14965" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=14965</a>).</pre><pre><br></pre><pre><br></pre></div></blockquote></div><br></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</div></blockquote></div><br></body></html>