[llvm] r179957 - SimplifyCFG: If convert single conditional stores

Chandler Carruth chandlerc at google.com
Sat Apr 20 18:19:48 PDT 2013


On Sat, Apr 20, 2013 at 11:44 PM, Arnold <aschwaighofer at apple.com> wrote:

> Given that there are potential positive secondary effects of having longer
> basic blocks I believe the overall effect to be positive.
>
> Also I believe in the short term the machine if conversation pass is not
> in the shape to be turned on and this opt temporarily improves things until
> it can (possibly) be superceeded by machine if conversation.
>

These two arguments were *exactly* the ones I used, and they were very
loudly objected to by everyone I mentioned. I largely agreed with you, but
also saw the concerns put forward by others. They were very firm and
demanded the patch be reverted. I don't even know *exactly* how similar the
patches are, but at the very least I think there should be a discussion and
explanation of what has changed since then. Otherwise, we have inconsistent
and confusing direction on how to develop any and all of these passes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130421/d19d8b4d/attachment.html>


More information about the llvm-commits mailing list