[PATCH] Allow users to choose identity used to sign tools.

[Filipe Cabecinhas]

filcab added you to the CC list for the revision "Allow users to choose identity used to sign tools.".

Hi echristo,

No change if the identity isn't defined by the makefile.
And use the long form for the sign flag.

http://llvm-reviews.chandlerc.com/D632

Files:
  Makefile.rules

Index: Makefile.rules
===================================================================
--- Makefile.rules
+++ Makefile.rules
@@ -1515,14 +1515,17 @@
 endif
 
 ifdef CODESIGN_TOOLS
+CODESIGN_IDENTITY ?= -
+
 $(ToolBuildPath): $(ObjectsO) $(ProjLibsPaths) $(LLVMLibsPaths)
 	$(Echo) Linking $(BuildMode) executable $(TOOLNAME) $(StripWarnMsg)
 	$(Verb) $(Link) -o $@ $(TOOLLINKOPTS) $(ObjectsO) $(ProjLibsOptions) \
 	$(LLVMLibsOptions) $(ExtraLibs) $(TOOLLINKOPTSB) $(LIBS)
 	$(Echo) ======= Finished Linking $(BuildMode) Executable $(TOOLNAME) \
           $(StripWarnMsg)
-	$(Echo) ======= Code-Signing $(BuildMode) Executable $(TOOLNAME)
-	$(Verb) codesign -s - $@
+	$(Echo) ======= Code-Signing $(BuildMode) Executable $(TOOLNAME) \
+          with identity $(CODESIGN_IDENTITY)
+	$(Verb) codesign --sign $(CODESIGN_IDENTITY) $@
 else
 $(ToolBuildPath): $(ObjectsO) $(ProjLibsPaths) $(LLVMLibsPaths)
 	$(Echo) Linking $(BuildMode) executable $(TOOLNAME) $(StripWarnMsg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D632.1.patch
Type: text/x-patch
Size: 976 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130405/99022513/attachment.bin>