[llvm] r177113 - [fast-isel] The X86FastISel::FastLowerArguments function doesn't properly handle
Chad Rosier
mcrosier at apple.com
Tue Apr 2 09:33:16 PDT 2013
On Apr 1, 2013, at 11:39 PM, Anton Korobeynikov <anton at korobeynikov.info> wrote:
> Hi Chad,
>
>> + if (Subtarget->isTargetWindows())
>> + return false;
>> +
> The patch is not correct. isTargetWindows() currently means
> "msvc-compatible", so this way you broken mingw64. It probably should
> be isTargetWin64().
>
> Note that SelectRet() and DoSelectCall() correctly use isTargetWin64() here.
>
> Please correct, thanks!
Committed revision 178549.
Thanks for pointing this out, Anton!
Chad
> --
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130402/fe4670f3/attachment.html>
More information about the llvm-commits
mailing list