[llvm] r177113 - [fast-isel] The X86FastISel::FastLowerArguments function doesn't properly handle

Anton Korobeynikov anton at korobeynikov.info
Mon Apr 1 23:39:31 PDT 2013


Hi Chad,

> +  if (Subtarget->isTargetWindows())
> +    return false;
> +
The patch is not correct. isTargetWindows() currently means
"msvc-compatible", so this way you broken mingw64. It probably should
be isTargetWin64().

Note that SelectRet() and DoSelectCall() correctly use isTargetWin64() here.

Please correct, thanks!

--
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University



More information about the llvm-commits mailing list