[PATCH] Fix DecodeT2LdStPre

Bill Wendling wendling at apple.com
Mon Mar 25 23:06:15 PDT 2013


On Mar 25, 2013, at 2:42 PM, Joe Abbey <jabbey at arxan.com> wrote:

> Patch by Gordon Keiser, with test case!
> 
> This patch addresses failure to decode encoding T4 of LDR (A8.8.62) and is a postindexed load, where the offset 0xc is applied to SP after the load occurs.   Rn is decoded with DecodeGPRRegisterClass but Rt is decoded (in what I assume is either a typo or misreading of the ARM manuals) with DecoderGPRRegisterClass.   Note the wonderful differentiation with the lowercase "r".   In any case, if PC or SP is the destination, the disassembler erroneously failed with the invalid encoding, despite the manual saying that both are fine.   
> 
Ew...the names are unfortunate. Is there a better name than DecoderGPRegisterClass?

> Ok to commit?
> 
LGTM. Thanks!

-bw





More information about the llvm-commits mailing list