[llvm] r177296 - Fix 80-col. violations in PPCCTRLoops

Sean Silva silvas at purdue.edu
Mon Mar 18 16:41:39 PDT 2013


> +          int64_t count = ImmVal -
> +            int64_t(short(DefInstr->getOperand(1).getImm()));
>

This piece of code is confusing. Why is it casting to `short`? If it just
doing it to mask to 16-bit, I'd rather see that done explicitly with `&
0xFFFF` instead of assuming that the host's `short` is 16 bits.

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130318/c6a8c772/attachment.html>


More information about the llvm-commits mailing list