[PATCH] Disable statistics on Release builds and move tests that depend on -stats.
Jordan Rose
jordan_rose at apple.com
Fri Mar 8 14:22:02 PST 2013
Thanks for checking with us, Jan. This looks fine.
On Mar 8, 2013, at 13:57 , Jan Voung <jvoung at chromium.org> wrote:
> Thanks for the review Chris!
>
> The original LLVM patch still applies, but I'd missed the fact that a few Clang tests also depend on Statistic.h.
>
> +cfe-commits
>
> Here is a follow on patch for Clang that moves 2 tests that use "-analyzer-stats", which I think depends on stats.
>
>
>
>
> On Fri, Mar 8, 2013 at 1:15 PM, Chris Lattner <clattner at apple.com> wrote:
> On Mar 1, 2013, at 3:35 PM, Jan Voung <jvoung at chromium.org> wrote:
>> Statistics are still available in Release+Asserts (or any +Asserts builds),
>> and they can also be turned on with LLVM_ENABLE_STATS.
>>
>> Also change some of the FastISel stats that were moved under DEBUG()
>> back out of DEBUG(), since stats are disabled across the board now.
>>
>> Many tests depend on grepping "-stats" output. Move those into
>> a orig_dir/Stats/. so that they can be marked as unsupported
>> when building without statistics.
>
> Looks great to me! Please commit,
>
> -Chris
>
>
> <0001-Move-clang-tests-that-depend-on-llvm-ADT-Statistic.h.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130308/03bd06e4/attachment.html>
More information about the llvm-commits
mailing list