<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Thanks for checking with us, Jan. This looks fine.</div><div><br></div><br><div><div>On Mar 8, 2013, at 13:57 , Jan Voung <<a href="mailto:jvoung@chromium.org">jvoung@chromium.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><div dir="ltr">Thanks for the review Chris!<div><br></div><div>The original LLVM patch still applies, but I'd missed the fact that a few Clang tests also depend on Statistic.h.</div><div><br></div><div>+cfe-commits</div><div><br></div><div>Here is a follow on patch for Clang that moves 2 tests that use "-analyzer-stats", which I think depends on stats.</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Mar 8, 2013 at 1:15 PM, Chris Lattner<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:clattner@apple.com" target="_blank">clattner@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;"><div><div class="h5"><div>On Mar 1, 2013, at 3:35 PM, Jan Voung <<a href="mailto:jvoung@chromium.org" target="_blank">jvoung@chromium.org</a>> wrote:</div><blockquote type="cite"><div dir="ltr"><span style="font-family: arial, sans-serif; font-size: 13px;">Statistics are still available in Release+Asserts (or any +Asserts builds),</span><br style="font-family: arial, sans-serif; font-size: 13px;"><span style="font-family: arial, sans-serif; font-size: 13px;">and they can also be turned on with LLVM_ENABLE_STATS.</span><br style="font-family: arial, sans-serif; font-size: 13px;"><br style="font-family: arial, sans-serif; font-size: 13px;"><span style="font-family: arial, sans-serif; font-size: 13px;">Also change some of the FastISel stats that were moved under DEBUG()</span><br style="font-family: arial, sans-serif; font-size: 13px;"><span style="font-family: arial, sans-serif; font-size: 13px;">back out of DEBUG(), since stats are disabled across the board now.</span><br style="font-family: arial, sans-serif; font-size: 13px;"><br style="font-family: arial, sans-serif; font-size: 13px;"><span style="font-family: arial, sans-serif; font-size: 13px;">Many tests depend on grepping "-stats" output. Move those into</span><br style="font-family: arial, sans-serif; font-size: 13px;"><span style="font-family: arial, sans-serif; font-size: 13px;">a orig_dir/Stats/. so that they can be marked as unsupported</span><br style="font-family: arial, sans-serif; font-size: 13px;"><span style="font-family: arial, sans-serif; font-size: 13px;">when building without statistics.</span></div></blockquote><br></div></div><div>Looks great to me! Please commit,</div><div><br></div><div>-Chris</div><br></div></blockquote></div><br></div><span><0001-Move-clang-tests-that-depend-on-llvm-ADT-Statistic.h.patch></span>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></div></blockquote></div><br></body></html>