[llvm] r176214 - The FastISEL should be fast. But when we record statistics we use atomic operations to increment the counters.

Bill Wendling wendling at apple.com
Wed Feb 27 14:46:20 PST 2013


On Feb 27, 2013, at 2:30 PM, Nadav Rotem <nrotem at apple.com> wrote:

>> Hey, good idea. Wonder if we should do this in general and make statistics gathering dependent upon NDEBUG?
>>  
>> -      unsigned NumFastIselRemaining = std::distance(Begin, End);
>> +      unsigned NumFastIselRemaining = 0;
>> +      NumFastIselRemaining = std::distance(Begin, End);
>> 
>> Eh?
>>  
> 
> I wanted to silence a warning because this variable is unused in Release.  Do you prefer that I silence it in another way ?
> 
The canonical way is to cast it to 'void':

	unsigned NumFastIselRemaining = std::distance(Begin, End);
	(void)NumFastIselRemaining;


-bw



More information about the llvm-commits mailing list