[llvm] r176214 - The FastISEL should be fast. But when we record statistics we use atomic operations to increment the counters.

Nadav Rotem nrotem at apple.com
Wed Feb 27 14:30:31 PST 2013


Hi Eric, 

> 
> This patch disables the counters on non-debug builds. This reduces the runtime of SelectionDAGISel::SelectCodeCommon by ~5%.
> 

Most of the statistics numbers are under #ifndef NDEBUG. 

> Hey, good idea. Wonder if we should do this in general and make statistics gathering dependent upon NDEBUG?
>  
> -      unsigned NumFastIselRemaining = std::distance(Begin, End);
> +      unsigned NumFastIselRemaining = 0;
> +      NumFastIselRemaining = std::distance(Begin, End);
> 
> Eh?
>  

I wanted to silence a warning because this variable is unused in Release.  Do you prefer that I silence it in another way ?

Thanks,
Nadav
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130227/f14586dd/attachment.html>


More information about the llvm-commits mailing list