[llvm] r175961 - Make some fixes for LiveInterval repair with debug info. Debug value

Cameron Zwarich zwarich at apple.com
Sat Feb 23 14:09:04 PST 2013


On Feb 23, 2013, at 12:26 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Sat, Feb 23, 2013 at 12:23 PM, Cameron Zwarich <zwarich at apple.com> wrote:
> Running it on test-suite with -g caused assertions to fail, so I assumed that was good enough.
> 
> Generally we prefer to have regression tests checked in with code changes - the test suite is used to catch things we failed to test but we take the opportunity to fix/improve the regression test coverage when the test-suite uncovers something.

That is generally the case for LLVM, but for experimental codegen changes in the past we have generally used the test-suite without adding a LIT test for every issue. Maybe that should change (and it would be easier to do if we had codegen tests that could just run a single pass), but it's nothing unusual.

Cameron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130223/15ef18bc/attachment.html>


More information about the llvm-commits mailing list