[llvm] r175633 - Revert r175626, "ADT/Optional.h: Appease msvc."

[Anna Zaks]

Our MSVC buildbot is back to red after the revert.

Anna.
On Feb 20, 2013, at 8:26 AM, David Blaikie <dblaikie at gmail.com> wrote:

> 
> On Feb 20, 2013 7:54 AM, "NAKAMURA Takumi" <geek4civic at gmail.com> wrote:
> >
> > Author: chapuni
> > Date: Wed Feb 20 09:52:44 2013
> > New Revision: 175633
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=175633&view=rev
> > Log:
> > Revert r175626, "ADT/Optional.h: Appease msvc."
> >
> > Sorry, I didn't cover +Asserts, by accident. :(
> 
> Hmm, what went wrong?
> 
> >
> > Modified:
> >     llvm/trunk/include/llvm/ADT/Optional.h
> >
> > Modified: llvm/trunk/include/llvm/ADT/Optional.h
> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/Optional.h?rev=175633&r1=175632&r2=175633&view=diff
> > ==============================================================================
> > --- llvm/trunk/include/llvm/ADT/Optional.h (original)
> > +++ llvm/trunk/include/llvm/ADT/Optional.h Wed Feb 20 09:52:44 2013
> > @@ -70,7 +70,7 @@ public:
> >
> >    void reset() {
> >      if (hasVal) {
> > -      (**this).~T();
> > +      (*this)->~T();
> >        hasVal = false;
> >      }
> >    }
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130220/226cf007/attachment.html>