<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Our MSVC buildbot is back to red after the revert.</div><div><br></div><div>Anna.<br><div><div>On Feb 20, 2013, at 8:26 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><p dir="ltr"><br>
On Feb 20, 2013 7:54 AM, "NAKAMURA Takumi" <<a href="mailto:geek4civic@gmail.com">geek4civic@gmail.com</a>> wrote:<br>
><br>
> Author: chapuni<br>
> Date: Wed Feb 20 09:52:44 2013<br>
> New Revision: 175633<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=175633&view=rev">http://llvm.org/viewvc/llvm-project?rev=175633&view=rev</a><br>
> Log:<br>
> Revert r175626, "ADT/Optional.h: Appease msvc."<br>
><br>
> Sorry, I didn't cover +Asserts, by accident. :(</p><p dir="ltr">Hmm, what went wrong?</p><p dir="ltr">><br>
> Modified:<br>
> llvm/trunk/include/llvm/ADT/Optional.h<br>
><br>
> Modified: llvm/trunk/include/llvm/ADT/Optional.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/Optional.h?rev=175633&r1=175632&r2=175633&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/Optional.h?rev=175633&r1=175632&r2=175633&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/ADT/Optional.h (original)<br>
> +++ llvm/trunk/include/llvm/ADT/Optional.h Wed Feb 20 09:52:44 2013<br>
> @@ -70,7 +70,7 @@ public:<br>
><br>
> void reset() {<br>
> if (hasVal) {<br>
> - (**this).~T();<br>
> + (*this)->~T();<br>
> hasVal = false;<br>
> }<br>
> }<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>
_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>