[llvm] r175382 - Add support for updating the LiveIntervals of registers used by 'exotic'

[Cameron Zwarich]

On Feb 16, 2013, at 6:22 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:

> On Feb 16, 2013, at 4:10 PM, Cameron Zwarich <zwarich at apple.com> wrote:
> 
>> +    void repairIntervalsInRange(MachineBasicBlock *MBB,
>> +                                MachineBasicBlock::reverse_iterator RBegin,
>> +                                MachineBasicBlock::reverse_iterator REnd,
>> +                                SmallVectorImpl<unsigned> &OrigRegs);
> 
> I think it is too confusing to use reverse_iterators in an API. Can't you keep that detail internal to the function? Better yet, just use -- to move backwards.

I originally wrote it that way, but it felt awkward since we are iterating backwards over an interval (A, B] not forward over an interval [A, B). I guess you are just suggesting that I do the conversion from left-open to right-open intervals in the function itself. Now that I am writing more uses in the two-address pass I might agree with that being the better option...

> Also, ArrayRef.

Will do.

Cameron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130216/e5428085/attachment.html>