[llvm] r175382 - Add support for updating the LiveIntervals of registers used by 'exotic'

[Jakob Stoklund Olesen]

On Feb 16, 2013, at 4:10 PM, Cameron Zwarich <zwarich at apple.com> wrote:

> +    void repairIntervalsInRange(MachineBasicBlock *MBB,
> +                                MachineBasicBlock::reverse_iterator RBegin,
> +                                MachineBasicBlock::reverse_iterator REnd,
> +                                SmallVectorImpl<unsigned> &OrigRegs);

I think it is too confusing to use reverse_iterators in an API. Can't you keep that detail internal to the function? Better yet, just use -- to move backwards.

Also, ArrayRef.

/jakob
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130216/79ed15d7/attachment.html>