[llvm] r175023 - Debug Info: LiveDebugVarible can remove DBG_VALUEs, make sure we emit them back.

[Eric Christopher]

On Wed, Feb 13, 2013 at 9:20 AM, Andrew Trick <atrick at apple.com> wrote:

>
> On Feb 12, 2013, at 10:00 PM, Eric Christopher <echristo at gmail.com> wrote:
>
>
>>  Any reason why these aren't going into the pass impl?
>>
>> They can be put in the pass impl. Is there an advantage of one vs. the
>> other?
>>
>>
> *shrug* Everything else in the implementation of the pass is in there...
> I'm at a loss on occasion why some things have pImpls. :)
>
>
>
> Private non-inline stuff should be in the pImpl. Sorry I missed that when
> I reviewed the diff.
>
> The MI sched specific test case is needed to hit this assertion. It
> invalidates LDV, which would then rerun on machine code sans-DGB_VALUEs.
> Not good.
>

Aha, that makes everything make a lot more sense.

Thanks Andy.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130213/11acae21/attachment.html>