<br><br><div class="gmail_quote">On Wed, Feb 13, 2013 at 9:20 AM, Andrew Trick <span dir="ltr"><<a href="mailto:atrick@apple.com" target="_blank">atrick@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div class="im"><br><div><div>On Feb 12, 2013, at 10:00 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:</div><blockquote type="cite">
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word">
<div><blockquote type="cite"><div class="gmail_quote"><br></div></blockquote></div><div><blockquote type="cite"><div class="gmail_quote"><div> Any reason why these aren't going into the pass impl?</div>
</div></blockquote></div>They can be put in the pass impl. Is there an advantage of one vs. the other?<div><br></div></div></blockquote><div><br></div><div>*shrug* Everything else in the implementation of the pass is in there... I'm at a loss on occasion why some things have pImpls. :)</div>
<div> </div></div></blockquote><br></div></div><div>Private non-inline stuff should be in the pImpl. Sorry I missed that when I reviewed the diff.</div><div><br></div><div>The MI sched specific test case is needed to hit this assertion. It invalidates LDV, which would then rerun on machine code sans-DGB_VALUEs. Not good.</div>
</div></blockquote><div><br></div><div>Aha, that makes everything make a lot more sense.</div><div><br></div><div>Thanks Andy.</div><div><br></div><div>-eric </div></div>