[llvm] r174632 - R600/SI: Add basic support for more integer vector types.

[Tom Stellard]

On Fri, Feb 08, 2013 at 05:04:10PM -0500, Sean Silva wrote:
> On Fri, Feb 8, 2013 at 4:40 PM, Tom Stellard <tom at stellard.net> wrote:
> 
> > On Thu, Feb 07, 2013 at 06:52:46PM -0500, Sean Silva wrote:
> > > Tests? (this applies to many other recent commits as well)
> >
> > All of the changes to the R600 are validated by the piglit test suite:
> > http://cgit.freedesktop.org/piglit
> >
> > However, we can always use more lit tests, and I will try to make sure
> > they are added when applicable.
> 
> 
> 
> Is piglit in the LLVM `test-suite` or being run by any of our buildbots? If
> you are relying on it to catch regressions, then it needs to be, otherwise
> your target will regress. Really though the benefit of lit tests is that
> every developer runs them on their machine and will be alerted to issues
> immediately.

It is not a part of the test-suite or run by any of the buildbots.
GPU test-suites aren't the best candidates for buildbots because they
often cause system hangs that require a manual reboot.

I know there is a risk of regression if we don't have full-test coverage
in the test-suite or in the lit tests, but as the backend code owner
I will take responsibility for identifying the regressions and working
with the developer to fix them.

-Tom