[llvm] r174080 - interpreter: Fix errant fallthrough.

[Alexander Kornienko]

Not sure, that phabricator sent you this. Repeating here.

This seems to be wrong. Your code will expand to:
case Type::IntegerTyID:
Dest.IntVal = Src.IntVal;
case Type::PointerTyID:
Dest.PointerVal = Src.PointerVal; break;
case Type::FloatTyID:
Dest.FloatVal = Src.FloatVal; break;
case Type::DoubleTyID:
Dest.DoubleVal = Src.DoubleVal; break;
break;

Which is probably not what you want.


On Thu, Jan 31, 2013 at 8:47 PM, Jim Grosbach <grosbach at apple.com> wrote:

> Author: grosbach
> Date: Thu Jan 31 13:46:59 2013
> New Revision: 174080
>
> URL: http://llvm.org/viewvc/llvm-project?rev=174080&view=rev
> Log:
> interpreter: Fix errant fallthrough.
>
> Modified:
>     llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp
>
> Modified: llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp?rev=174080&r1=174079&r2=174080&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp (original)
> +++ llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp Thu Jan 31
> 13:46:59 2013
> @@ -1169,10 +1169,12 @@ void Interpreter::visitVAArgInst(VAArgIn
>                        .VarArgs[VAList.UIntPairVal.second];
>    Type *Ty = I.getType();
>    switch (Ty->getTypeID()) {
> -    case Type::IntegerTyID: Dest.IntVal = Src.IntVal;
> +  case Type::IntegerTyID:
> +    Dest.IntVal = Src.IntVal;
>      IMPLEMENT_VAARG(Pointer);
>      IMPLEMENT_VAARG(Float);
>      IMPLEMENT_VAARG(Double);
> +    break;
>    default:
>      dbgs() << "Unhandled dest type for vaarg instruction: " << *Ty <<
> "\n";
>      llvm_unreachable(0);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Alexander Kornienko | Software Engineer | alexfh at google.com | +49 151 221
77 957
Google Germany GmbH | Dienerstr. 12 | 80331 München
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130201/c70795fe/attachment.html>