<div dir="ltr">Not sure, that phabricator sent you this. Repeating here.<div><br></div><div><p style="margin:0px 0px 1em;padding:0px;border:0px;color:rgb(0,0,0);font-family:'Helvetica Neue',Arial,sans-serif;font-size:13px;line-height:18.84375px;background-color:rgb(252,252,252)">
This seems to be wrong. Your code will expand to:<br>case Type::IntegerTyID:<br>Dest.IntVal = Src.IntVal;<br>case Type::PointerTyID:<br>Dest.PointerVal = Src.PointerVal; break;<br>case Type::FloatTyID:<br>Dest.FloatVal = Src.FloatVal; break;<br>
case Type::DoubleTyID:<br>Dest.DoubleVal = Src.DoubleVal; break;<br>break;</p><p style="margin:0px;padding:0px;border:0px;color:rgb(0,0,0);font-family:'Helvetica Neue',Arial,sans-serif;font-size:13px;line-height:18.84375px;background-color:rgb(252,252,252)">
Which is probably not what you want.</p></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jan 31, 2013 at 8:47 PM, Jim Grosbach <span dir="ltr"><<a href="mailto:grosbach@apple.com" target="_blank">grosbach@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: grosbach<br>
Date: Thu Jan 31 13:46:59 2013<br>
New Revision: 174080<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=174080&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=174080&view=rev</a><br>
Log:<br>
interpreter: Fix errant fallthrough.<br>
<br>
Modified:<br>
    llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp<br>
<br>
Modified: llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp?rev=174080&r1=174079&r2=174080&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp?rev=174080&r1=174079&r2=174080&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp (original)<br>
+++ llvm/trunk/lib/ExecutionEngine/Interpreter/Execution.cpp Thu Jan 31 13:46:59 2013<br>
@@ -1169,10 +1169,12 @@ void Interpreter::visitVAArgInst(VAArgIn<br>
                       .VarArgs[VAList.UIntPairVal.second];<br>
   Type *Ty = I.getType();<br>
   switch (Ty->getTypeID()) {<br>
-    case Type::IntegerTyID: Dest.IntVal = Src.IntVal;<br>
+  case Type::IntegerTyID:<br>
+    Dest.IntVal = Src.IntVal;<br>
     IMPLEMENT_VAARG(Pointer);<br>
     IMPLEMENT_VAARG(Float);<br>
     IMPLEMENT_VAARG(Double);<br>
+    break;<br>
   default:<br>
     dbgs() << "Unhandled dest type for vaarg instruction: " << *Ty << "\n";<br>
     llvm_unreachable(0);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div><font color="#666666"><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(213,15,37);border-right-color:rgb(213,15,37);border-bottom-color:rgb(213,15,37);border-left-color:rgb(213,15,37);padding-top:2px;margin-top:2px">Alexander Kornienko |</span><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(51,105,232);border-right-color:rgb(51,105,232);border-bottom-color:rgb(51,105,232);border-left-color:rgb(51,105,232);padding-top:2px;margin-top:2px"> Software Engineer |</span></font><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(0,153,57);border-right-color:rgb(0,153,57);border-bottom-color:rgb(0,153,57);border-left-color:rgb(0,153,57);padding-top:2px;margin-top:2px"><font color="#666666"> </font><a href="mailto:alexfh@google.com" style="color:rgb(17,85,204)" target="_blank">alexfh@google.com</a> |</span><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(238,178,17);border-right-color:rgb(238,178,17);border-bottom-color:rgb(238,178,17);border-left-color:rgb(238,178,17);padding-top:2px;margin-top:2px"> <a value="+35315435283" style="color:rgb(17,85,204)">+49 151 221 77 957</a></span></div>
</div><div><font color="#666666"><span style="background-color:rgb(255,255,255);font-family:Arial,Verdana,sans-serif">Google Germany GmbH | </span><span style="background-color:rgb(255,255,255);font-family:Arial,Verdana,sans-serif">Dienerstr. 12 | </span><span style="background-color:rgb(255,255,255);font-family:Arial,Verdana,sans-serif">80331 München</span></font></div>

</div>