[llvm-commits] [PATCH]: POC patch for specifying which sections to dump in llvm-dwarfdump

[Eli Bendersky]

Here's a full patch that addresses your comments, adds flags for all
sections and some testing.

Eli


On Fri, Jan 25, 2013 at 8:48 AM, Eli Bendersky <eliben at google.com> wrote:
> On Fri, Jan 25, 2013 at 8:44 AM, Eric Christopher <echristo at gmail.com> wrote:
>>
>>
>>> There were two reasons for this change:
>>>
>>> 1. General coding conventions consistency.
>>> 2. The first couple of times I saw that variable I had a slight wtf
>>> moment reading it "dict x" and getting confused. (yeah, too much
>>> Python, I know).
>>>
>>> However, I don't see it as a big deal, so if you feel strongly about
>>> keeping the old name, I'll remove it from the patch. No worries.
>>>
>>
>> Not particularly against it, if you want to just go ahead and commit it now
>> and not part of the other patch.
>>
>
> OK, I'll do that. Thanks.
>
> Eli
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-dwarfdump-dump-options.2.patch
Type: application/octet-stream
Size: 10856 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130125/94fab6af/attachment.obj>