[llvm-commits] [PATCH]: POC patch for specifying which sections to dump in llvm-dwarfdump

Eli Bendersky eliben at google.com
Fri Jan 25 08:48:28 PST 2013


On Fri, Jan 25, 2013 at 8:44 AM, Eric Christopher <echristo at gmail.com> wrote:
>
>
>> There were two reasons for this change:
>>
>> 1. General coding conventions consistency.
>> 2. The first couple of times I saw that variable I had a slight wtf
>> moment reading it "dict x" and getting confused. (yeah, too much
>> Python, I know).
>>
>> However, I don't see it as a big deal, so if you feel strongly about
>> keeping the old name, I'll remove it from the patch. No worries.
>>
>
> Not particularly against it, if you want to just go ahead and commit it now
> and not part of the other patch.
>

OK, I'll do that. Thanks.

Eli



More information about the llvm-commits mailing list