[llvm-commits] Cost Table, take 2

Nadav Rotem nrotem at apple.com
Wed Jan 23 11:32:48 PST 2013


I would like to see this patch go in, but since this patch addresses chandler's concerns I think that he should review it.  Chandler, do you mind taking a look ?
 

On Jan 23, 2013, at 1:28 AM, Renato Golin Linaro <renato.golin at linaro.org> wrote:

> Sorry, I should have said, Bump...
> 
> 
> On 23 January 2013 09:28, Renato Golin Linaro <renato.golin at linaro.org> wrote:
> Ping
> 
> 
> On 22 January 2013 11:08, Renato Golin Linaro <renato.golin at linaro.org> wrote:
> Hi folks,
> 
> The logic is still the same, but I've addressed most of your concerns.
> 
>  - Moved to ADT, no more spurious includes
>  - Made it a template on types and size
>  - Am only creating the temporary lookup object if necessary
> 
> I wonder if the TableLookup could be used for something else, so I tried to leave it as generic as possible and left plenty of comments (including Evan's worry about sorting tables) for later, if proven necessary.
> 
> Please review.
> 
> cheers,
> --renato
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130123/b959fc34/attachment.html>


More information about the llvm-commits mailing list