<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I would like to see this patch go in, but since this patch addresses chandler's concerns I think that he should review it. Chandler, do you mind taking a look ?<div> </div><div><div><br><div><div>On Jan 23, 2013, at 1:28 AM, Renato Golin Linaro <<a href="mailto:renato.golin@linaro.org">renato.golin@linaro.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Sorry, I should have said, Bump...</div><div class="gmail_extra"><br><br><div class="gmail_quote">On 23 January 2013 09:28, Renato Golin Linaro <span dir="ltr"><<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ping</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">
On 22 January 2013 11:08, Renato Golin Linaro <span dir="ltr"><<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi folks,<div><br></div><div>The logic is still the same, but I've addressed most of your concerns.</div>
<div><br></div><div> - Moved to ADT, no more spurious includes</div><div> - Made it a template on types and size</div>
<div> - Am only creating the temporary lookup object if necessary</div><div><br></div><div>I wonder if the TableLookup could be used for something else, so I tried to leave it as generic as possible and left plenty of comments (including Evan's worry about sorting tables) for later, if proven necessary.</div>
<div><br></div><div>Please review.</div><div><br></div><div>cheers,</div><div>--renato</div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</blockquote></div><br></div></div></body></html>